Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -pr for inspecting GitHub pull requests #11

Merged
merged 35 commits into from Mar 29, 2023
Merged

Add -pr for inspecting GitHub pull requests #11

merged 35 commits into from Mar 29, 2023

Conversation

bobg
Copy link
Owner

@bobg bobg commented Mar 20, 2023

New command-line flag -pr allows comparing the head of a GitHub pull-request branch with its base to produce a report like this one.

This PR also adds a new modver -pr check in this repo's GitHub Actions workflow.

It also fixes a problem in .gitignore, substantially refactors and adds test coverage in cmd/modver, and works around an apparent go-git bug that manifests in GitHub Actions.

@bobg
Copy link
Owner Author

bobg commented Mar 20, 2023

Modver result

This report was generated by Modver,
a Go package and command that helps you obey semantic versioning rules in your Go module.

This PR requires (at least) an increase in your module's minor version number.

checking Compare
  in parameters of func(olders []*golang.org/x/tools/go/packages.Package, newers []*golang.org/x/tools/go/packages.Package) github.com/bobg/modver/v2.Result
    struct field TypeErrors was added to golang.org/x/tools/go/packages.Package
      Minor

@bobg bobg marked this pull request as ready for review March 29, 2023 13:19
@bobg bobg merged commit e849b90 into master Mar 29, 2023
1 check passed
@bobg bobg deleted the pr branch March 29, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant