Fix: reRequiring files with naming collisions with mock-require #37

treygriffith · 2018-11-26T18:23:00Z

This change fixes #36 by making require.resolve explicit in where it is resolving from. It therefore prevents collisions with files in mock-require, which are themselves in the NODE_PATH, triggering the isInPath condition to return the mock-require file.

To illustrate the change I moved the module itself to the NODE_PATH for the test.

… node path

…e location to resolve from, rather than the mock-require module itself

treygriffith added 3 commits November 26, 2018 10:16

add test illustrating issues re-requiring when mock-require is in the…

1082eee

… node path

when resolving paths using require.resolve, use the caller file as th…

3f237d2

…e location to resolve from, rather than the mock-require module itself

make require resolution backward compatible

baeda0a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: reRequiring files with naming collisions with mock-require #37

Fix: reRequiring files with naming collisions with mock-require #37

treygriffith commented Nov 26, 2018

Fix: reRequiring files with naming collisions with mock-require #37

Are you sure you want to change the base?

Fix: reRequiring files with naming collisions with mock-require #37

Conversation

treygriffith commented Nov 26, 2018