[Partial fix] requires too many keystrokes for the standard use-case #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bodil#19 * moved 'open as new file' to action menu. * The extension will be loaded after vsCode startsup.
|
Partial fix. IMHO, the important one (at least for me :) ) is fixed. |
rbadapanda
changed the title
rbadapanda
commented
Dec 7, 2020
Comment on lines
+95
to
+101
| // this.current.value = ""; | ||
|
|
||
| const stat = (await Result.try(vscode.workspace.fs.stat(this.path.uri))).unwrap(); | ||
| if (stat && this.inActions && (stat.type & FileType.File) === FileType.File) { | ||
| const selectedFile = new Path(this.path.uri).pop().unwrap(); | ||
| this.items = [ | ||
| action("$(file) Open this file", Action.OpenFile), | ||
| action("$(split-horizontal) Open this file to the side", Action.OpenFileBeside), | ||
| action("$(edit) Rename this file", Action.RenameFile), | ||
| action("$(trash) Delete this file", Action.DeleteFile), | ||
| action(`$(new-file) Create file: ${this.current.value}`, Action.NewFile, this.current.value), |
There was a problem hiding this comment.
Found an issue with this code. but am not able to update another CR to this branch. Hence mentioning it here:
Modification:
line#95: Should remain as is. However, I would create a copy of the variable before resetting its value.
line#101: Use the new variable created on line#95
|
I forked this and pulled in this change (with some more improvements): https://github.com/jeffgran/vscode-quick-file-browser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19