-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable pydata_sphinx_theme version banner #13901
enable pydata_sphinx_theme version banner #13901
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-3.5 #13901 +/- ##
==============================================
+ Coverage 91.57% 93.15% +1.58%
==============================================
Files 326 282 -44
Lines 20737 20031 -706
==============================================
- Hits 18990 18660 -330
+ Misses 1747 1371 -376 |
Unfortunately that would be an enormous ordeal and undertaking. Also potentially costly, as well, as the pages are stored on s3 and we would have to exfiltrate many tens of thousands to update. We would also have to issue very large Cloudfront cache invalidations. I think we will just have to live with old pages being as they are until they are retired from the switcher list. Edit: Unless you mean just the top-level |
I haven't thought about updating only the start page but I think that would be a good compromise. It is not sufficent to show the version banner on all pages but it is much better than nothing and the start page should have this information. |
@bokeh/core after this is merged it would be advised to test a dev build release. |
Thanks @mosc9575 FYI I am about to be "out of the office" for a few weeks, maybe make a separate issue regarding updating the old |
@bryevdv Below is a zip folder with the adapted index pages. I adapted th current latest version, too. I hope this will work for you. |
* enable pydata_sphinx_theme version banner * add env var BOKEH_DOCS_VERSION to cons.py * remove version 3.4.0 from switcher.json
This PR activates the version banner from pydata-sphinx-theme, removes the old version banner (js and css). The switcher.json in also adapted to silence a warning.
After running
make clean html serve
on my local machine this is the result.For the older versions
it is suggested to add the code below to all existing html pages to enable the banner.
I don't know how to do this.