Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't read packages on each iteration #232

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

goodmind
Copy link

@goodmind goodmind commented May 22, 2019

  • Check for package.json file directly instead of looking for package.json in every folder
  • Add prepare lifecycle because prepublish doesn't work with git dependency
  • Don't read packages on each iteration

@goodmind
Copy link
Author

goodmind commented May 22, 2019

There's also bug that it reads node_modules tho, if it searches like this with glob recursively, and then creates infinite symlink causing ELOOP error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant