generated from boneskull/boneskull-template
-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a plugin system #402
Open
boneskull
wants to merge
104
commits into
main
Choose a base branch
from
plugin-support
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @boneskull and the rest of your teammates on Graphite |
This was referenced Oct 10, 2023
boneskull
force-pushed
the
plugin-support
branch
2 times, most recently
from
October 11, 2023 00:08
181aead
to
d55ad27
Compare
boneskull
force-pushed
the
plugin-support
branch
2 times, most recently
from
October 11, 2023 07:00
a5ad1ef
to
1758954
Compare
boneskull
force-pushed
the
plugin-support
branch
from
October 11, 2023 19:00
1758954
to
0fda84b
Compare
boneskull
force-pushed
the
plugin-support
branch
from
October 11, 2023 21:40
0fda84b
to
4ab8ed1
Compare
boneskull
force-pushed
the
plugin-support
branch
from
October 11, 2023 21:45
4ab8ed1
to
0896099
Compare
boneskull
force-pushed
the
plugin-support
branch
from
October 11, 2023 21:52
0896099
to
b666f7b
Compare
boneskull
force-pushed
the
plugin-support
branch
11 times, most recently
from
October 13, 2023 04:27
4bd3120
to
b9a5fd8
Compare
- the onus of getting a version from a dist-tag or range is now the responsibility of the package manager - remove `safePath` - remove `Errors` from `PluginAPI` - fix many tests
- ignore shebangs in adhoc scripts - re-enable `n/no-path-concat`
- rename a dir - extract "common" errors into their own files - add unit tests for `guessPackageManager()`
move to its own file
also remove a duplicate schema/type
boneskull
force-pushed
the
plugin-support
branch
from
March 14, 2024 22:27
dd0fdce
to
e105feb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a plugin system so we can separate things like rules (and eventually package manager implementations from the main codebase), and others can write custom plugins providing the same.
All rules have moved into the
@midnight-smoker/plugin-default-rules
package.Limitations
Plugins currently cannot interact with each other nor declare dependencies on other plugins. Eventually I imagine someone might want to, say, override a rule.
Plugins cannot yet add package managers.
TODO
Future
Smoker
is a vanillaEventEmitter
, which is problematic if listeners are async.