Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#795] Fixed lazy instantiation for some fields of WebDriverManager #796

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

jensbac
Copy link
Contributor

@jensbac jensbac commented Feb 27, 2022

Purpose of changes

fix for issue #795

Types of changes

Fixed lazy instantiation for fields resolutionCache, versionDetector and webDriverCreator of WebDriverManager.

  • Bug-fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

New version was build locally and included to an using project.

WebDriverManager.chromiumdriver().setup() now produces the log output:

[DEBUG] Detecting chromium version using online commands.properties
[DEBUG] Running command on the shell: [chromium-browser, --version]
[DEBUG] Result: Chromium 98.0.4758.102 snap
[DEBUG] Latest version of chromedriver according to https://chromedriver.storage.googleapis.com/LATEST_RELEASE_98 is 98.0.4758.102
[INFO] Using chromedriver 98.0.4758.102 (resolved driver for Chromium 98)
[DEBUG] Found CHROMIUM snap
[INFO] Exporting webdriver.chrome.driver as /snap/bin/chromium.chromedriver

instead of downloading a chromedriver.

Notes:

  • Nevertheless due to Selenium issue 7788 starting the snap installed chromedriver does not work on e.g. Ubuntu 20.04. But the workaround described there does the job.
  • mvn verify executed for this fixed version continues complaining about 10 failing tests when executed on Ubuntu 20.04 with snap installed chromium and chromium.chromedriver but no installation of google-chrome (same as without the fix). These are related to WebDriverManager.chromedriver().setup() which cannot detect a google-chrome but downloads and starts a chromedriver which finally starts a chromium but cannot control it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants