feat/timeline-chart #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oin. Added formating for XAxis on chart based on selected timeline. Added diferent colors for charts
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/app/components/CoinChart.tsx
Outdated
Comment on lines
114
to
136
| const formatDateGraphs = (tick: string): string => { | ||
| const date = new Date(tick); | ||
| let formattedDate: string; | ||
|
|
||
| if (days === "1") { | ||
| formattedDate = date.toLocaleTimeString(undefined, { | ||
| hour: "2-digit", | ||
| minute: "2-digit", | ||
| hour12: false, | ||
| }); | ||
| } else if (["7", "14", "30"].includes(days)) { | ||
| formattedDate = date.toLocaleDateString(undefined, { | ||
| day: "numeric", | ||
| month: "short", | ||
| }); | ||
| } else if (["90", "180", "365", "max"].includes(days)) { | ||
| formattedDate = date.toLocaleDateString(undefined, { | ||
| day: "numeric", | ||
| month: "short", | ||
| year: "numeric", | ||
| }); | ||
| } else { | ||
| formattedDate = date.toLocaleDateString(); |
There was a problem hiding this comment.
This could be moved to a utility file from where you can export formatDateGraphs function because it does not depend on a state, it is a pure JS function.
There was a problem hiding this comment.
Good one. It makes sense to move it to utility folder as separate function. It makes code so much cleaner. Doing it right now.
src/app/page.tsx
Outdated
| <div className="mt-10 max-w-[1440px] mx-auto xl:px-[72px] lg:px-[36px] md:px-[24px]"> | ||
| <Timeline /> | ||
| </div> | ||
| <div className="mt-10"></div> |
There was a problem hiding this comment.
Why do we have this empty div?
src/app/components/CoinChart.tsx
Outdated
|
|
||
| setCurrentValue(`${lastValue.toFixed(2)}`); | ||
| setCurrentDate(lastDate); | ||
| } | ||
| }, [selectedCoins, chartType, currencyCode]); | ||
|
|
||
| if (loading === "pending") { | ||
| /* if (loading === "pending") { |
There was a problem hiding this comment.
Do we need this commented out code?
src/app/components/Timeline.tsx
Outdated
Comment on lines
13
to
25
| <button | ||
| className={`w-14 p-1 ${ | ||
| t.active | ||
| ? "bg-[rgb(120,120,250,0.7)] border border-[#7878FA] shadow-md rounded-md" | ||
| : "" | ||
| }`} | ||
| onClick={() => dispatch(activeTimeline(t.id))} | ||
| key={t.id} | ||
| > | ||
| <span className="dark:text-[#E4E4F0] text-[#181825] text-sm"> | ||
| {t.display} | ||
| </span> | ||
| </button> |
There was a problem hiding this comment.
This could be moved into it's own separate component. What will you name this component?
abhishekjakhar
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the selected timeline display chart for price and volume.