Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BFormFile): add properties placement and browser as in BootstrapVue #1797

Merged
merged 10 commits into from Apr 2, 2024

Conversation

anrolmar
Copy link
Contributor

@anrolmar anrolmar commented Feb 25, 2024

Describe the PR

  • Add properties placement and browser as in BootstrapVue
  • Add unit tests for the whole component

Small replication

I checked the documentation of the old component (https://bootstrap-vue.org/docs/components/form-file)

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 馃悰 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

A虂ngel Rolda虂n Marti虂nez added 6 commits February 4, 2024 08:24
add properties placement and browser as in BootstrapVue
add missing properties from bootstrap-vue
add unit tests
add unit tests for input and label attributes
add unit tests for input and label attributes
Copy link

stackblitz bot commented Feb 25, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

A虂ngel Rolda虂n Marti虂nez added 2 commits March 24, 2024 10:15
add createReusableTemplate for managing the browser text placementto feat_BFormFile
fix unit tests
@VividLemon VividLemon merged commit 2fe4e69 into bootstrap-vue-next:main Apr 2, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Apr 2, 2024
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Apr 4, 2024
* upstream/main:
  fix(BFormFile): add properties placement and browser as in BootstrapVue (bootstrap-vue-next#1797)
  feat(BCheckbox)!: Implement reverse and without label (bootstrap-vue-next#1825)
  docs: Add documentation and parity section to contributing.md (bootstrap-vue-next#1834)
  vscode vue typescript plugin is now depricated and included in volar
  feat(BOffcanvas): add props backdropBlur and shadow to customize the BOverlay instance
  fix(BFormTags): limitTagsText props is not used fixes bootstrap-vue-next#1804
  fix(BTable): BTable rowDblClicked event not working fixes bootstrap-vue-next#1795
  open/close -> show/hide (bootstrap-vue-next#1813)
  fix(BDropdown): ignore keynav inside form (bootstrap-vue-next#1812)
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Apr 16, 2024
* upstream/main:
  ci: add workflow dispatch to docs deploy
  chore: release main
  fix(BFormCheckbox): Prevent empty string being cast to true fixes bootstrap-vue-next#1822
  feat(utils): inject getId to allow for custom id generation (bootstrap-vue-next#1836)
  BTable multisort (bootstrap-vue-next#1842)
  fix(BFormSelect): array of numbers or dates (bootstrap-vue-next#1839)
  fix(BPopover and Btooltip): Fixes bootstrap-vue-next#1232 - do not create a new app fro each tooltip or popover (bootstrap-vue-next#1837)
  fix(BFormFile): add properties placement and browser as in BootstrapVue (bootstrap-vue-next#1797)
  feat(BCheckbox)!: Implement reverse and without label (bootstrap-vue-next#1825)
  docs: Add documentation and parity section to contributing.md (bootstrap-vue-next#1834)
  vscode vue typescript plugin is now depricated and included in volar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants