Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

open/close -> show/hide #1813

Merged
merged 2 commits into from Mar 12, 2024
Merged

open/close -> show/hide #1813

merged 2 commits into from Mar 12, 2024

Conversation

xvaara
Copy link
Contributor

@xvaara xvaara commented Mar 12, 2024

BEGIN_COMMIT_OVERRIDE
fix(BDropdown)!: change open/close to show/hide in expose and slots
fix(BCollapse)!: change open/close to show/hide in expose and slots
END_COMMIT_OVERRIDE

Describe the PR

A clear and concise description of what the pull request does.

Small replication

A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 馃悰 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

Copy link

stackblitz bot commented Mar 12, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@xvaara xvaara requested a review from VividLemon March 12, 2024 16:50
@xvaara xvaara merged commit cd7aaf2 into bootstrap-vue-next:main Mar 12, 2024
3 checks passed
@xvaara xvaara deleted the show-hide branch March 12, 2024 20:36
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Apr 4, 2024
* upstream/main:
  fix(BFormFile): add properties placement and browser as in BootstrapVue (bootstrap-vue-next#1797)
  feat(BCheckbox)!: Implement reverse and without label (bootstrap-vue-next#1825)
  docs: Add documentation and parity section to contributing.md (bootstrap-vue-next#1834)
  vscode vue typescript plugin is now depricated and included in volar
  feat(BOffcanvas): add props backdropBlur and shadow to customize the BOverlay instance
  fix(BFormTags): limitTagsText props is not used fixes bootstrap-vue-next#1804
  fix(BTable): BTable rowDblClicked event not working fixes bootstrap-vue-next#1795
  open/close -> show/hide (bootstrap-vue-next#1813)
  fix(BDropdown): ignore keynav inside form (bootstrap-vue-next#1812)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants