feat(BCheckbox)!: Implement reverse and without label #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dwgray
changed the title
VividLemon
requested changes
Mar 22, 2024
| required: toRef(() => props.required), | ||
| buttons: toRef(() => props.buttons), | ||
| disabled: toRef(() => props.disabled), | ||
| }) | ||
|
|
||
| watch(modelValue, (newValue) => { |
There was a problem hiding this comment.
I am a fan of this change, emitting events for this when it really is just a copy of modelvalue is strange. However, first: it needs to be labeled as a breaking change commit. Second: BFormRadioGroup also has this same code, but it is not removed.
dwgray
changed the title
6 tasks
|
Closing the PR and opening #1825 with amended commit messages |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Implement the reverse and without-label features of checkboxes and radio buttons.
Reverse is implemented as a property on BFormCheckbox and BFormCheckboxGroup
Without Labels is implemented by not including the form-checkbox class when there is no default slot
In addition:
I believe that this PR brings us to parity with BSV legacy and BS5. There is some more clean-up to do with BFormRadio, I didn't intend to touch that at all, but since there was a shared component I did the minimum to get the core feature I was working on to work with Radio controls.
Small replication
A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)feat(...)fix(...)docs(...)The PR fulfills these requirements:
CHANGELOGis generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be deniedBREAKINGCHANGE: BFormCheckboxGroup and BFormRadioGroup no longer emit
inputorchangeevents - please use update:modelValue instead