Skip to content

Commit

Permalink
fix: remove underscore form variable and method names (#3352)
Browse files Browse the repository at this point in the history
  • Loading branch information
jacobmllr95 committed May 22, 2019
1 parent d44fba5 commit bcd0a2f
Show file tree
Hide file tree
Showing 8 changed files with 129 additions and 129 deletions.
2 changes: 1 addition & 1 deletion src/components/form-checkbox/form-checkbox-group.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export default Vue.extend({
}
},
computed: {
is_RadioGroup() {
isRadioGroup() {
return false
}
}
Expand Down
8 changes: 4 additions & 4 deletions src/components/form-checkbox/form-checkbox.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export default Vue.extend({
}
},
computed: {
is_Checked() {
isChecked() {
const checked = this.computedLocalChecked
const value = this.value
if (isArray(checked)) {
Expand All @@ -60,10 +60,10 @@ export default Vue.extend({
return looseEqual(checked, value)
}
},
is_Radio() {
isRadio() {
return false
},
is_Check() {
isCheck() {
return true
}
},
Expand Down Expand Up @@ -105,7 +105,7 @@ export default Vue.extend({
// Change is only emitted on user interaction
this.$emit('change', checked ? value : uncheckedValue)
// If this is a child of form-checkbox-group, we emit a change event on it as well
if (this.is_Group) {
if (this.isGroup) {
this.bvGroup.$emit('change', localChecked)
}
this.$emit('update:indeterminate', indeterminate)
Expand Down
2 changes: 1 addition & 1 deletion src/components/form-radio/form-radio-group.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default Vue.extend({
}
},
computed: {
is_RadioGroup() {
isRadioGroup() {
return true
}
}
Expand Down
8 changes: 4 additions & 4 deletions src/components/form-radio/form-radio.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,14 @@ export default Vue.extend({
},
computed: {
// Radio Groups can only have a single value, so determining if checked is simple
is_Checked() {
isChecked() {
return looseEqual(this.value, this.computedLocalChecked)
},
// Flags for form-radio-check mixin
is_Radio() {
isRadio() {
return true
},
is_Check() {
isCheck() {
return false
}
},
Expand All @@ -55,7 +55,7 @@ export default Vue.extend({
// Change is only emitted on user interaction
this.$emit('change', checked ? value : null)
// If this is a child of form-radio-group, we emit a change event on it as well
if (this.is_Group) {
if (this.isGroup) {
this.bvGroup.$emit('change', checked ? value : null)
}
}
Expand Down

0 comments on commit bcd0a2f

Please sign in to comment.