Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update devdependency babel-eslint to ^10.0.3 #3941

Merged
merged 2 commits into from
Aug 26, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 25, 2019

This PR contains the following updates:

Package Type Update Change
babel-eslint devDependencies patch ^10.0.2 -> ^10.0.3

Release Notes

babel/babel-eslint

v10.0.3

Compare Source

Fixes #​791, also eslint/eslint#​12117

Some context: #​793 (comment)

We ended up going with @​JLHwung's PR #​794 which uses ESLint's deps instead of going with peerDeps since it really depends on the version being used and we don't want users to have to install it directly on their own.

babel-eslint is patching patches of the dependencies of ESLint itself so these kinds of issues have happened in the past. We'll need to look into figuring out how to have a more solid way of modifying behavior instead of this monkeypatching type of thing for future releases.


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@codecov
Copy link

codecov bot commented Aug 25, 2019

Codecov Report

Merging #3941 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3941   +/-   ##
=======================================
  Coverage   99.33%   99.33%           
=======================================
  Files         233      233           
  Lines        4494     4494           
  Branches     1269     1269           
=======================================
  Hits         4464     4464           
  Misses         24       24           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5079dd...71ae7e1. Read the comment docs.

@tmorehouse
Copy link
Member

tmorehouse commented Aug 25, 2019

@jackmu95 Supposedly this fixes the eslint problems from the other PR.

babel/babel-eslint#794
babel/babel-eslint#791 (comment)

Once this is merged we can try and un-pin eslint (in package.json) and un-ignore eslint in renovate.json

@jacobmllr95
Copy link
Member

@tmorehouse It does fix the issue. Included it directly into this PR.

@renovate
Copy link
Contributor Author

renovate bot commented Aug 26, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@tmorehouse tmorehouse merged commit 7a3b350 into dev Aug 26, 2019
@tmorehouse tmorehouse deleted the renovate/all-minor-patch branch August 26, 2019 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants