New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(b-modal): remove role="document"
from .modal-content
#5345
Conversation
…et `role="dialog"` when `.modal` is visible
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/kst0d9kbz |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6759967:
|
Codecov Report
@@ Coverage Diff @@
## dev #5345 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 281 281
Lines 8828 8829 +1
Branches 2505 2505
=========================================
+ Hits 8828 8829 +1
Continue to review full report at Codecov.
|
role="document"
from .modal-content
and only set role="dialog"
when .modal
is visiblerole="document"
from .modal-content
Will just have to test with a few screen readers to ensure the modal is properly announced (title, etc) when it opens. |
Describe the PR
This PR removes the no longer needed
role="document"
from.modal-content
.Ref: twbs/bootstrap#30687
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: