setup.py: fix import error reporting for cythonize import, see #8208 #8211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 1.2-maint #8211 +/- ##
=============================================
- Coverage 82.55% 82.54% -0.01%
=============================================
Files 38 38
Lines 10838 10838
Branches 2079 2079
=============================================
- Hits 8947 8946 -1
- Misses 1340 1341 +1
Partials 551 551 ☔ View full report in Codecov by Sentry. |
…ckup#8208 Looks like borg's setup.py has hidden the real cause of a cythonize ImportError. There are basically 2 cases: - either there is no Cython installed, then the import fails because the module can not be found, or - there is some issue within Cython and the import fails due to that. It's important not to hide the real cause, especially if we run into case 2. case 1 is kind of expected and frequent, case 2 is rare.
That "failed to map segment from shared object" error msg is not very helpful. Add a hint that the filesystem needs to be +exec (== not noexec mounted, like it might be the case for /tmp on some systems).
ThomasWaldmann
force-pushed
the
fix-cythonize-import-error-reporting-1.2
branch
from
2ae58dd
to
8470730
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like borg's setup.py has hidden the real cause of a cythonize ImportError.
There are basically 2 cases:
It's important not to hide the real cause, especially if we run into case 2.
case 1 is kind of expected and frequent, case 2 is rare.