Fix stderr color dependence on stdout #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I renamed the references to the coloring feature from Lines 10 to 12 in f12a2b3 That may be a mistake please let me know if I should roll that back. |
|
Thanks! I think this will fix #71 too.
I think this change makes sense, I'm not really sure why it was written that way, since There's some documentation around |
mergify bot
pushed a commit
to andrzejressel/pulumi-wasm
that referenced
this pull request
Apr 30, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [simple_logger](https://togithub.com/borntyping/rust-simple_logger) | workspace.dependencies | major | `4.3.3` -> `5.0.0` | --- ### Release Notes <details> <summary>borntyping/rust-simple_logger (simple_logger)</summary> ### [`v5.0.0`](https://togithub.com/borntyping/rust-simple_logger/releases/tag/v5.0.0) [Compare Source](https://togithub.com/borntyping/rust-simple_logger/compare/v4.3.3...v5.0.0) #### What's Changed - Fix stderr color dependence on stdout by [@​spoutn1k](https://togithub.com/spoutn1k) in [borntyping/rust-simple_logger#91 - When using the `stderr` and `colors` features, logs will be printed in colour even when STDOUT is redirected. - Fixes [#​71](https://togithub.com/borntyping/rust-simple_logger/issues/71). - This also cleans up the feature names used in the code. All references should now be to the `colors` feature, not the `colored` dependency. - Removed `set_up_color_terminal` from the public API. This has been called by `init()` for a while now. #### New Contributors - [@​spoutn1k](https://togithub.com/spoutn1k) made their first contribution in [borntyping/rust-simple_logger#91 **Full Changelog**: borntyping/rust-simple_logger@v4.3.3...v5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/andrzejressel/pulumi-wasm).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I work with programs that pipe
stdoutoften.simple_loggerwould simply not print colored output tostderrwhen that happened. This is due to thiscoloredissue.This PR aims to fix this by implementing a variation of the
set_up_color_terminalfunction, enabled when thestderrfeature is selected on other platforms than Windows (For lack of testing environment).