Using a function reference instead of calling directly from constructor

bower · Mar 24, 2015 · a352d51 · a352d51
1 parent 4ad5ed6
commit a352d51
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/lib/core/resolvers/GitHubResolver.js b/lib/core/resolvers/GitHubResolver.js
@@ -38,7 +38,9 @@ function GitHubResolver(decEndpoint, config, logger) {
     }
 
     // Enable shallow clones for GitHub repos
-    this._shallowClone = Q.resolve(true);
+    this._shallowClone = function() {
+        return Q.resolve(true);
+    };
 }
 
 util.inherits(GitHubResolver, GitRemoteResolver);

diff --git a/lib/core/resolvers/GitRemoteResolver.js b/lib/core/resolvers/GitRemoteResolver.js
@@ -29,7 +29,7 @@ function GitRemoteResolver(decEndpoint, config, logger) {
     this._remote = url.parse(this._source);
 
     // Verify whether the server supports shallow cloning
-    this._shallowClone = this._supportsShallowCloning();
+    this._shallowClone = this._supportsShallowCloning;
 }
 
 util.inherits(GitRemoteResolver, GitResolver);
@@ -117,7 +117,7 @@ GitRemoteResolver.prototype._fastClone = function (resolution) {
     branch = resolution.tag || resolution.branch;
     args = ['clone',  this._source, '-b', branch, '--progress', '.'];
 
-    return this._shallowClone.then(function (shallowCloningSupported) {
+    return this._shallowClone().then(function (shallowCloningSupported) {
         // If the host does not support shallow clones, we don't use --depth=1
         if (shallowCloningSupported && !GitRemoteResolver._noShallow.get(this._host)) {
             args.push('--depth', 1);

diff --git a/test/core/resolvers/gitRemoteResolver.js b/test/core/resolvers/gitRemoteResolver.js
@@ -287,7 +287,7 @@ describe('GitRemoteResolver', function () {
 
             var resolver = new MyGitRemoteResolver({ source: testSource }, defaultConfig(), logger);
 
-            resolver._shallowClone.then(function (shallowCloningSupported) {
+            resolver._shallowClone().then(function (shallowCloningSupported) {
                 expect(shallowCloningSupported).to.be(false);
 
                 next();
@@ -307,7 +307,7 @@ describe('GitRemoteResolver', function () {
 
             var resolver = new MyGitRemoteResolver({ source: testSource }, defaultConfig(), logger);
 
-            resolver._shallowClone.then(function (shallowCloningSupported) {
+            resolver._shallowClone().then(function (shallowCloningSupported) {
                 expect(shallowCloningSupported).to.be(false);
 
                 next();
@@ -327,7 +327,7 @@ describe('GitRemoteResolver', function () {
 
             var resolver = new MyGitRemoteResolver({ source: testSource }, defaultConfig(), logger);
 
-            resolver._shallowClone.then(function (shallowCloningSupported) {
+            resolver._shallowClone().then(function (shallowCloningSupported) {
                 expect(shallowCloningSupported).to.be(true);
 
                 next();