Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra newline at the end of help-cache.std #1576

Merged
merged 1 commit into from Oct 27, 2014
Merged

Add extra newline at the end of help-cache.std #1576

merged 1 commit into from Oct 27, 2014

Conversation

darabos
Copy link
Contributor

@darabos darabos commented Oct 27, 2014

Without this newline, the template is rendered without a newline at the end. So when you run grunt help cache, the output does not have a newline at the end and the shell prompt will be printed at the end of the last line. It looks like this:

darabos@ramhegy:~$ bower help cache

Usage:

    bower cache <command> [<args>] [<options>]
Commands:

    clean                   Clean cached packages
    list                    List cached packagesdarabos@ramhegy:~$ 

This patch is the simplest fix (I tried it and it works). But another option is to trim the output in util/template.js and explicitly add one newline at the end. That would be less error prone -- how long before someone deletes this seemingly unnecessary newline? If you'd prefer that solution I can send a PR for that.

Thanks for Bower!

Without this newline, the template is rendered without a newline at the end. So when you run `grunt help cache`, the output does not have a newline at the end and the shell prompt will be printed at the end of the last line.
sindresorhus added a commit that referenced this pull request Oct 27, 2014
Add extra newline at the end of help-cache.std
@sindresorhus sindresorhus merged commit 7db5039 into bower:master Oct 27, 2014
@sheerun sheerun mentioned this pull request Mar 11, 2015
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants