Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Prefix the choice with ! to persist it to bower.json" needs a line break #1639

Closed
davidsneighbour opened this issue Jan 1, 2015 · 4 comments
Closed

"Prefix the choice with ! to persist it to bower.json" needs a line break #1639

davidsneighbour opened this issue Jan 1, 2015 · 4 comments
Labels
bug help wanted

Comments

@davidsneighbour
Copy link
Contributor

Just a small flaw: If a bower.json configuration exists and I run

bower install --save-dev PACKAGENAME

where the PACKAGENAME is already noted in the bower.json it asks me to choose a version. The last line says "Prefix the choice with ! to persist it to bower.json". There should most probably be a linebreak (or two) before that sentence, see screenshot.

2015-01-01-20 11 35
@sheerun
Copy link
Contributor

sheerun commented Jan 4, 2015

Mind to send a PR?

@davidsneighbour
Copy link
Contributor Author

I have a commit here aad253b but I am not sure how to test if this works. Is there a guide somewhere how to compile my local bower from this repo?

@sheerun
Copy link
Contributor

sheerun commented Jan 5, 2015

Test is not necessary if you're sure it fixes the problem. Just send a PR :)

@davidsneighbour davidsneighbour mentioned this issue Jan 5, 2015
Merged
sheerun added a commit that referenced this issue Jan 5, 2015
@sheerun
Merge pull request #1644 from pkollitsch/typo
d5c1360 
Fix for #1639, missing line break in CLI input
@sheerun
Copy link
Contributor

sheerun commented Jan 5, 2015

Fixed via #1644

@sheerun sheerun closed this as completed Jan 5, 2015
insanehong pushed a commit to insanehong/bower that referenced this issue Mar 6, 2015
@davidsneighbour @insanehong
Fix for bower#1639, missing line break in CLI input
16be650
@sheerun sheerun mentioned this issue Mar 11, 2015
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidsneighbour @sheerun