Changed smart Git host detection #1766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only check the first Content-Type returned by the server. Some hosts are returning text/plain in the first response, and then the correct content type in later responses. This seems to be the case for GitHub Enterprise. By checking the first content type entry, we should be able to verify this. Also added unit tests to test this behavior.
|
@anwalkers Could you confirm it fixes your issue? |
|
👍 this is great @nwinkler really amazing work |
|
Please don't merge this yet - I'm not certain at all whether this is a good fix for the problem. We've already seen that it doesn't work for some people. Essentially, it looks like the smart Git protocol support is not related to support for shallow cloning. At the moment, I don't know whether we're evaluating the wrong thing, or whether we're dealing with a bug on GitHub Enterprise. I'm doing some more research now (and I'm going to contact GitHub Enterprise support). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only check the first Content-Type returned by the server. Some hosts are
returning text/plain in the first response, and then the correct content
type in later responses. This seems to be the case for GitHub
Enterprise. By checking the first content type entry, we should be able
to verify this.
Also added unit tests to test this behavior.
This should hopefully fix #1764 for most people.