Decompress gzip files

[Utsav2]

Update request lib.

This fixes #2090 and #1004, but I'm not sure how to unit test it.

I tried it with the example given in #1004

bower install --save-dev hellosign=http://s3.amazonaws.com/cdn.hellofax.com/js/embedded.js

and it works.

In short, if request notices a gzipped file, it decompresses it. We need to add the option there because request doesn't do it automatically (for backward compatibility reasons).

[0q98ahdsg3987y1h987y]

👍 Nice work!

[contolini]

Nice job!

Some testing thoughts: Reply headers can be specified with nock. Try adding a test to test/util/download.js that mocks the downloading of a text file with a 'Content-Encoding': 'gzip' header. After it's downloaded, if you can successfully read its contents with fs.readFileSync, the test passes and satisfies #1004.

For #2090, use the same test as above but add .gz to the end of the text file.

If you need any help, find us on chat.

[Utsav2]

@contolini Thanks for the tips. Just to clarify, I should add a gzipped file to tests/assets and test against that, right?

[sheerun]

@Utsav2 Yes, you can use nock's "replyWithFile" helper and .txt file encoded with gzip you put in test/assets.

[Utsav2]

@sheerun How does it look now?

[sheerun]

LGTM :)