Fix name clashes in package extraction #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent extraction failing if a package archive contains a file with the same name as the archive, or a single directory with a subdirectory with the same name.
|
|
||
| // Create an archive containing the main package | ||
| var archiveDeferred = Q.defer(); | ||
| var archivePath = path.join(parentDir, mainPackageBaseName + ".tar") |
|
Make sure to do |
Add missing semicolons to test file.
al3rez
pushed a commit
that referenced
this pull request
Jan 1, 2016
Fix name clashes in package extraction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent extraction failing if a package archive contains a file with the same name as the archive, or a single directory with a subdirectory with the same name.
The former was picked up from a TODO in the codebase, the latter from #1935.