Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use caret on install save #2145

Merged
merged 1 commit into from Jan 12, 2016
Merged

Use caret on install save #2145

merged 1 commit into from Jan 12, 2016

Conversation

samccone
Copy link
Member

This fix brings us inline with how npm installs work and also brings us
more inline with how semver is supposed to be used.

Fixes #2144

This fix brings us inline with how npm installs work and also brings us
more inline with how semver is supposed to be used.

Fixes #2144
@sheerun
Copy link
Contributor

sheerun commented Jan 11, 2016

Probably we should put it in bower 2.0?

@samccone
Copy link
Member Author

hmm, I was thinking if this is a "breaking" change.. but I think that it is not, it is not impacting old bower.json files, and just will change the behavior a tiny bit on new installs, which brings it inline more with what people expect.

@benmann
Copy link
Member

benmann commented Jan 12, 2016

Thought about that too and I'm all for it, however I also agree with @sheerun. Doesn't the caret ignore 0.x version updates? I don't think it will really break old packages either but people unaware of that change might be confused, especially for dependencies. We should at least communicate this very clearly.

@samccone
Copy link
Member Author

Doesn't the caret ignore 0.x version updates

pretty sure no :)

image

image

@benmann
Copy link
Member

benmann commented Jan 12, 2016

In that case.. ignore everything I just said 👻
So the only real difference is in the minor range? ..Where being more inclusive is a plus imho.

@samccone
Copy link
Member Author

👍 , I will let @sheerun make the final call on this one

@sheerun
Copy link
Contributor

sheerun commented Jan 12, 2016

I bet I'll regret it, but let's try :)

sheerun added a commit that referenced this pull request Jan 12, 2016
@sheerun sheerun merged commit 8cf897c into master Jan 12, 2016
@samccone
Copy link
Member Author

ha @sheerun :)

@samccone samccone deleted the sjs/use-caret-on-install-save branch January 12, 2016 21:24
@benmann
Copy link
Member

benmann commented Jan 12, 2016

We can always blame @samccone 😇
..I think it'll be fine though

@samccone
Copy link
Member Author

🔥 🏃

-------^ me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Should bower install default to caret?
4 participants