Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove analytics from Bower, fixes #1102 #2150

Merged
merged 1 commit into from Jan 20, 2016
Merged

Remove analytics from Bower, fixes #1102 #2150

merged 1 commit into from Jan 20, 2016

Conversation

sheerun
Copy link
Contributor

@sheerun sheerun commented Jan 19, 2016

They caused more issues than useful they were.

Instead, we'll focus on fetching statistics from NPM registry to watch Bower's popularity, and GitHub stars over time to watch packages' popularity.

http://bower.io/stats/ is already updated to use only non-google-analytics data.

@sheerun
Copy link
Contributor Author

sheerun commented Jan 19, 2016

@samccone
Copy link
Member

Code change: LGTM 👍


broader question:

If someone runs bower i... with silent... and they have not configured their prefs yet (I am thinking of the run on CI test case) can we just assume no tracking?

The only reason I ask is because losing these metrics is a fairly big hit imho.

@benmann
Copy link
Member

benmann commented Jan 19, 2016

Ship Ahoy! All looking good 🚢
And yep, we're ditching stats for command usage.
(Or which specific metric are we talking about? ;D)

@sheerun
Copy link
Contributor Author

sheerun commented Jan 19, 2016

@samccone We already assumed no analytics on CI. Plus I don't know any way we used these metrics to develop bower.. And nowadays we also "freeze" bower releases with bundledDependencies.

Developers reporting issues on Github do far better job than analytics of how many times someone wrote bower install. Actually useful thing would be auto crash-reports, but analytics in current form seems not.

@samccone
Copy link
Member

sounds good to me @sheerun

🚢 away

@desandro
Copy link
Member

👍 Thanks for the work here

@mojoaxel
Copy link

👍
Hopefully the depedency on insight can be removed as well!?

@sheerun
Copy link
Contributor Author

sheerun commented Jan 20, 2016

@mojoaxel Good catch :)

They caused more issues than useful they were.

Instead, we'll focus on fetching statistics from
NPM registry to watch Bower's popularity, and
GitHub stars over time to watch packages' popularity.
sheerun added a commit that referenced this pull request Jan 20, 2016
Remove analytics from Bower, fixes #1102
@sheerun sheerun merged commit fe615fd into master Jan 20, 2016
@sheerun sheerun deleted the feature/analytics branch January 20, 2016 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants