Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose non-interactive option to CLI help #2404

Merged
merged 3 commits into from
Mar 28, 2018
Merged

Conversation

mischah
Copy link
Contributor

@mischah mischah commented Dec 12, 2016

That’s it :octocat:

Related to #1162
Having that option in the CLI help would have saved my a few minutes.

@mischah mischah force-pushed the extend-help branch 2 times, most recently from ae177a2 to 4e73766 Compare December 12, 2016 13:35
@benmann
Copy link
Member

benmann commented Dec 12, 2016

Was actually under the impression it's --non-interactive. I might be wrong but the changelog mentions it 🤔 What also should work is --config.interactive=false

@mischah
Copy link
Contributor Author

mischah commented Dec 12, 2016

Sorry. I double checked it a few minutes ago.

Both of these don’t prevent prompts:

bower install  --no-interactive
bower install  --non-interactive

But this do:

bower install --config.interactive=false

Going to force push this change in a minute.

@mischah
Copy link
Contributor Author

mischah commented Dec 12, 2016

Done. But I’m not sure if this feels right.

Should it be:

{
  "flag":        "--config",
  "description": "Set and override settings from .bowerrc eg. `--config.interactive=false`"
}

instead of:

{
  "flag":        "--config.interactive=false",
  "description": "Disable prompts"
}

@mischah
Copy link
Contributor Author

mischah commented Dec 12, 2016

I’m totally confused cause according to 8f0a3d7 (PR: #1969) there should be a --non-interactive option 😕

I have currently no time to dig deeper in the sources.

Please let me now if you want any changes to this PR.

@mischah mischah changed the title Expose no-interactive option to CLI help Expose non-interactive option to CLI help Dec 12, 2016
@mischah
Copy link
Contributor Author

mischah commented Dec 19, 2016

Is there anything I can do to help to get this merged?

@benmann
Copy link
Member

benmann commented Dec 19, 2016

I was just hoping for some more opinions, as I understand your feeling that it doesn't seem entirely "right" using --config. However I think it's an often needed/looked up feature, so I'm cool with merging this. Can you squash the commits (or somehow re-trigger the CI)?

@mischah
Copy link
Contributor Author

mischah commented Dec 19, 2016

We could wait for a few days if there are other opinions especially about that comment above: #2404 (comment)

@mischah mischah force-pushed the extend-help branch 2 times, most recently from 72ee313 to e0896d4 Compare December 19, 2016 21:29
@mischah
Copy link
Contributor Author

mischah commented May 23, 2017

Any additional feedback? Will this get merged?

Going to close this otherwise 😗

@sheerun sheerun merged commit c3e9c94 into bower:master Mar 28, 2018
@mischah mischah deleted the extend-help branch March 28, 2018 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants