chore(build): upgrade webpack and babel #3482
Conversation
Upgrade webpack, babel-loader, webpack-cli, and other babel packages Remove legacy openssl options during build
package.json
Outdated
| "webpack-bundle-analyzer": "^3.6.0", | ||
| "webpack-cli": "^3.3.10", | ||
| "webpack-cli": "^4.9.1", |
There was a problem hiding this comment.
This upgrade is required due to receiving the error in webpack/webpack-cli#3005, after upgrading webpack and babel-loader
There are higher versions available, but I decided to use the lowest version which includes the fix to avoid any issues. https://github.com/webpack/webpack-cli/releases/tag/webpack-cli%404.9.1
If we want to upgrade more, I think we should do it in a separate PR.
There was a problem hiding this comment.
I went ahead and updated to latest in this PR
| @@ -34,12 +34,6 @@ be.activitySidebarFilter.status.tasks = Tasks | |||
| be.add = Add | |||
| # Text to display when app is disabled by applied access policy | |||
| be.additionalTab.blockedByShieldAccessPolicy = Use of this app is blocked due to a security policy. | |||
| # Error message when an annotation deletion fails | |||
There was a problem hiding this comment.
It always seems to be updated whenever I run yarn build. I can leave it out if you'd like, since I don't have a good idea of when we include changes from build vs not. When do we want to include changes vs not?
There was a problem hiding this comment.
I think these types of changes should be included when we delete the reference in the code. You can still see the translation used in the code here
. It's probably deleted when you do yarn:build because it's in an object 🤷♀️ We should probably change it so that it's not deleted when you run yarn:build but in a different PR.replace proposals upgrade webpack-cli to latest
Pin @types/react to resolve mismatches between different versions
WIP - other build failures, see circleci
Upgrade webpack, babel-loader, webpack-cli, and other babel packages
Remove legacy openssl options during build
Purposefully did not remove proposal plugins or unused babel packages - should do in another PR.
To test this PR, make sure you remove node_modules and your existing yarn.lock, and run a fresh
yarn install. Direct upgrades caused errors (not just warnings).There are currently warnings about css ordering, e.g.
These errors began after upgrading webpack, babel, and webpack-cli. In other words, these were not triggered or resolved by the various css loader upgrades. There's an informative thread at facebook/create-react-app#5372 which suggests that we could have ambiguous css imports. However, the root cause is unclear, as is any proof of actual impact.