Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Npm] Adds sqlite data backend #1046

Closed
wants to merge 1 commit into from
Closed

[Npm] Adds sqlite data backend #1046

wants to merge 1 commit into from

Conversation

mghwaz
Copy link

@mghwaz mghwaz commented Mar 27, 2023

What does this PR do?

This adds,

  • sqlite backend support.

Type of change

  • Updated dependencies
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Existing unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ghost
Copy link

ghost commented Mar 27, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@deepakprabhakara
Copy link
Member

Thanks @mghwaz, this would be great. I think the TypeORM models could be shared unless sqlite has major differences.

@deepakprabhakara
Copy link
Member

Closing in lieu of #2729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mghwaz @deepakprabhakara @meghfossa