biosnoop.bt: use block tracepoints #2875
Conversation
makelinux
requested review from
ajor,
viktormalik,
danobi and
fbs
as code owners
makelinux
force-pushed
the
biosnoop
branch
2 times, most recently
from
2951111
to
7d45d18
Compare
|
Needs a rebase I think. But otherwise good to merge. Sorry - this fell thru the cracks |
|
Ah ok, so I was getting confused about Just one question though: when I run biosnoop during But my Doesn't seem correct that pacman writes/reads from |
because since v5.17-rc1~116^2~83 functions blk_account_io_start and blk_account_io_done became static and can't be used as kprobes. Using major and minor because unfortunately disk_name is not exported to tracepoints. Tested on linux-6.5 and linux-4.18
|
Good catch! Fixed.
…On Sun, 28 Jan 2024 at 21:19, Daniel Xu ***@***.***> wrote:
Ah ok, so I was getting confused about dev_t cuz apparently kernel dev_t
is different than the one userspace sees: https://lwn.net/Articles/50703/
. So that all looks good.
Just one question though: when I run biosnoop during sudo pacman -Syu, I
see a lot of:
10497 259:1 pacman 270981 0
10499 259:1 pacman 270981 0
10499 259:1 pacman 270981 0
10500 259:1 pacman 270981 0
10502 259:1 pacman 270981 0
10502 259:1 pacman 270981 0
10503 259:1 pacman 270981 0
But my lsblk shows:
nvme0n1 259:0 0 953.9G 0 disk
├─nvme0n1p1 259:1 0 1G 0 part /boot
├─nvme0n1p2 259:2 0 32G 0 part [SWAP]
└─nvme0n1p3 259:3 0 920.9G 0 part /
Doesn't seem correct that pacman writes/reads from /boot. It should be
from /, right? Any ideas?
—
Reply to this email directly, view it on GitHub
<#2875 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR2DUNVJFQCWREUCV6SOFLYQ2QDHAVCNFSM6AAAAABAOZNKDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGY4TKNRQGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Ha, With fix, it looks like all activity is going to minor number 0. Is that expected? I'm not too familiar with block layer semantics for this case |
The same major or another? |
|
The same major as before (correct one I think) |
|
I don't know. |
since functions blk_account_io_start and blk_account_io_done became static and can't be used as kprobes.
Using major and minor because unfortunately disk_name is not exported to tracepoints.
Checklist
CHANGELOG.md