Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve indication of strict validation mode #831

Open
nikku opened this issue Dec 14, 2022 · 3 comments
Open

Improve indication of strict validation mode #831

nikku opened this issue Dec 14, 2022 · 3 comments
Labels
backlog Queued in backlog enhancement New feature or request ux

Comments

@nikku
Copy link
Member

nikku commented Dec 14, 2022

Is your feature request related to a problem? Please describe

As I edit properties in the panel elements get validated in strict or lax mode. In strict validation mode we don't serialize critical properties (ID) thus maintaining the integrity of the underlying model.

Unfortunately we don't indicate to the user that the contents of the element are not accepted, leading to unpleasant surprises. As a user I cannot distinguish strict and lax mode.

capture gy1n4S_optimized

Describe the solution you'd like

  • Restore valid in strict mode immediately after the element is blurred.

Describe alternatives you've considered

Add additional, visual indication to distinguish strict from lax validation mode.

Additional context

This issue was previously user reported, it is especially confusing in the context of element templates, where strict validation is currently applies (when it should not).

@nikku nikku added the enhancement New feature or request label Dec 14, 2022
@nikku
Copy link
Member Author

nikku commented Dec 14, 2022

@pinussilvestrus do you have context why we decided to implement it this way (don't restore on blur)?

@pinussilvestrus
Copy link
Contributor

As far as I can remember we simply re-used the same validation approach as in the 0.x properties panel.
: bpmn-io/properties-panel#27

@nikku
Copy link
Member Author

nikku commented Dec 14, 2022

Thanks @pinussilvestrus. That helps a lot. The referenced issue explicitly states:

[...] the last valid input value should be restored.

(Without mentioning when the restoration shall happen, which is crucial 🙈).

@nikku nikku added the ux label Dec 19, 2022
@marstamm marstamm added the backlog Queued in backlog label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog enhancement New feature or request ux
Development

No branches or pull requests

3 participants