Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relaxed validation for element templates #832

Open
nikku opened this issue Dec 14, 2022 · 1 comment
Open

Use relaxed validation for element templates #832

nikku opened this issue Dec 14, 2022 · 1 comment
Labels
backlog Queued in backlog element templates enhancement New feature or request ux

Comments

@nikku
Copy link
Member

nikku commented Dec 14, 2022

Is your feature request related to a problem? Please describe

In the properties panel we currently have two validation modes:

  • A strict mode, only applying for critical properties (ID)
  • A lax mode, where invalid user contents will be accepted, but indicated through linting

In strict mode we do not serialized changed values with the goal to maintain the integrity of the model. Applying it in the context of element templates leads to unpleasant surprises (#831).

Describe the solution you'd like

  • Validate element template bindings in relaxed mode
  • Keep error indication on the panel

Describe alternatives you've considered

Keep existing validation in place.

Additional context

None.


Related to #831

@nikku
Copy link
Member Author

nikku commented Dec 19, 2022

CC @christian-konrad

@marstamm marstamm added the backlog Queued in backlog label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog element templates enhancement New feature or request ux
Development

No branches or pull requests

2 participants