fix: make constructors open for extension

bpmn-io · Apr 4, 2023 · 9c3d27e · 9c3d27e
1 parent 466a2ac
commit 9c3d27e
Show file tree

Hide file tree

Showing 6 changed files with 57 additions and 7 deletions.
diff --git a/lib/BaseModeler.spec.ts b/lib/BaseModeler.spec.ts
@@ -6,4 +6,17 @@ const modeler = new BaseModeler({
   container: 'container'
 });
 
-testViewer(modeler);
+testViewer(modeler);
+
+
+const otherModeler = new BaseModeler({
+  container: 'container'
+});
+
+const extendedModeler = new BaseModeler({
+  container: 'container',
+  alignToOrigin: false,
+  propertiesPanel: {
+    attachTo: '#properties-panel'
+  }
+});
diff --git a/lib/BaseViewer.d.ts b/lib/BaseViewer.d.ts
@@ -20,7 +20,7 @@ export type BaseViewerOptions = {
   container?: string|HTMLElement;
   moddleExtensions?: ModdleExtensions;
   additionalModules?: ModuleDeclaration[];
-};
+} & Record<string, any>;
 
 export type ModdleElement = Object;
 

diff --git a/lib/BaseViewer.spec.ts b/lib/BaseViewer.spec.ts
@@ -6,9 +6,9 @@ import BaseViewer, { Events } from './BaseViewer';
 
 import OverlaysModule from 'diagram-js/lib/features/overlays';
 
-let viewer = new BaseViewer();
+const viewer = new BaseViewer();
 
-viewer = new BaseViewer({
+const configuredViewer = new BaseViewer({
   width: 100,
   height: 100,
   position: 'absolute',
@@ -23,6 +23,14 @@ viewer = new BaseViewer({
 
 testViewer(viewer);
 
+const extendedViewer = new BaseViewer({
+  container: 'container',
+  alignToOrigin: false,
+  propertiesPanel: {
+    attachTo: '#properties-panel'
+  }
+});
+
 export function testViewer(viewer: BaseViewer) {
   viewer.importXML('<?xml version="1.0" encoding="UTF-8"?>', 'BPMNDiagram_1');
 

diff --git a/lib/Modeler.spec.ts b/lib/Modeler.spec.ts
@@ -8,4 +8,17 @@ const modeler = new Modeler({
 
 testViewer(modeler);
 
-modeler.createDiagram();
+modeler.createDiagram();
+
+
+const otherModeler = new Modeler({
+  container: 'container'
+});
+
+const extendedModeler = new Modeler({
+  container: 'container',
+  alignToOrigin: false,
+  propertiesPanel: {
+    attachTo: '#properties-panel'
+  }
+});
diff --git a/lib/NavigatedViewer.spec.ts b/lib/NavigatedViewer.spec.ts
@@ -6,4 +6,12 @@ const viewer = new NavigatedViewer({
   container: 'container'
 });
 
-testViewer(viewer);
+testViewer(viewer);
+
+const extendedViewer = new NavigatedViewer({
+  container: 'container',
+  alignToOrigin: false,
+  propertiesPanel: {
+    attachTo: '#properties-panel'
+  }
+});
diff --git a/lib/Viewer.spec.ts b/lib/Viewer.spec.ts
@@ -6,4 +6,12 @@ const viewer = new Viewer({
   container: 'container'
 });
 
-testViewer(viewer);
+testViewer(viewer);
+
+const extendedViewer = new Viewer({
+  container: 'container',
+  alignToOrigin: false,
+  propertiesPanel: {
+    attachTo: '#properties-panel'
+  }
+});