Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy/paste of event-subprocess turns non-interrupting message start event to untyped start event #1696

Closed
rajgoel opened this issue Jul 11, 2022 · 6 comments · Fixed by #1699
Assignees
Labels
bug Something isn't working good first issue Good for newcomers spring cleaning Could be cleaned up one day

Comments

@rajgoel
Copy link

rajgoel commented Jul 11, 2022

Describe the Bug

When copy/pasting an event-subprocess on demo.bpmn.io the type of the start event is not correctly copied.

After copying and before pasting the modeller shows:

Copy

After pasting the modeller shows:

Paste

Steps to Reproduce

  1. Create an event-subprocess in https://demo.bpmn.io/new
  2. Change start event to non-interrupting message start event
  3. Select event-subprocess and press CTRL-C
  4. Press CTRL-V and click

Expected Behavior

The type of the start event should be the same as in the original event-subprocess.

Environment

@rajgoel
Copy link
Author

rajgoel commented Jul 11, 2022

Interestingly, copying a non-interrupting start event into an existing event-subprocess appears to work as expected in the demo modeller.

@philippfromme
Copy link
Contributor

philippfromme commented Jul 11, 2022

Hey, thanks for creating this issue. I've looked into it and it seems to be an issue with ReplaceBehavior. It checks against the rules whether an element should be replaced after it was created. In the case of the start event, it performs the check assuming the process is the parent, not the sub-process. Therefore the start event gets replaced.

We will try and get this fixed soon. 👍🏻

@philippfromme philippfromme added backlog Queued in backlog spring cleaning Could be cleaned up one day good first issue Good for newcomers labels Jul 11, 2022
@philippfromme philippfromme self-assigned this Jul 12, 2022
@philippfromme philippfromme added ready Ready to be worked on and removed backlog Queued in backlog labels Jul 12, 2022
@philippfromme
Copy link
Contributor

Same issue as camunda/camunda-modeler#2438.

@rajgoel
Copy link
Author

rajgoel commented Jul 12, 2022

Just tried out this fix 7141624 by @barmac and it appears to solve the issue.

@philippfromme
Copy link
Contributor

Just tried out this fix 7141624 by @barmac and it appears to solve the issue.

I'm currently working on this. Expect this to be fixed very soon.

@philippfromme
Copy link
Contributor

philippfromme commented Jul 13, 2022

Closed via #1699.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers spring cleaning Could be cleaned up one day
Development

Successfully merging a pull request may close this issue.

2 participants