Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append preview not cleaned up when deleting element through keyboard #2150

Closed
philippfromme opened this issue Apr 26, 2024 · 1 comment · Fixed by #2152
Closed

Append preview not cleaned up when deleting element through keyboard #2150

philippfromme opened this issue Apr 26, 2024 · 1 comment · Fixed by #2152
Assignees
@philippfromme
Labels
bug Something isn't working

Comments

@philippfromme
Copy link
Contributor

Describe the Bug

When deleting an element using the keyboard while there is a preview the preview doesn't get cleaned up.

brave_acVJ3O7hd2

Steps to Reproduce

  1. Show append preview through hover
  2. Delete selected element through keyboard
  3. Preview not cleaned up

Expected Behavior

Preview always cleaned up.

Environment

  • Library version: 17.3.0
@philippfromme philippfromme added the bug Something isn't working label Apr 26, 2024
@philippfromme philippfromme self-assigned this Apr 26, 2024
@philippfromme philippfromme added the in progress Currently worked on label Apr 29, 2024 — with bpmn-io-tasks
@philippfromme philippfromme mentioned this issue Apr 29, 2024
Merged
philippfromme added a commit that referenced this issue Apr 29, 2024
@philippfromme
fix(context-pad): remove append preview on context pad close
84b8cbc 
Closes #2150
@philippfromme philippfromme mentioned this issue Apr 29, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Apr 29, 2024
philippfromme added a commit that referenced this issue Apr 29, 2024
@philippfromme
fix(context-pad): remove append preview on context pad close
407a191 
Closes #2150
@github-actions github-actions bot mentioned this issue Apr 29, 2024
Closed
@nikku
Copy link
Member

nikku commented May 3, 2024

Closed via #2152.

@nikku nikku closed this as completed May 3, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippfromme philippfromme

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(context-pad): remove append preview on context pad close bpmn-io/bpmn-js
2 participants
@nikku @philippfromme