Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(context-pad): do not call triggerEntry twice when handling hover #890

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Apr 29, 2024

Didn't break anything but would call triggerEntry with non-existing action. Discovered in the context of bpmn-io/bpmn-js#2150.

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Apr 29, 2024
@philippfromme philippfromme changed the base branch from develop to main April 29, 2024 09:39
@philippfromme
Copy link
Contributor Author

Follow-up: bpmn-io/bpmn-js#2152

@philippfromme philippfromme merged commit bc6ee49 into main Apr 29, 2024
11 of 12 checks passed
@philippfromme philippfromme deleted the fix-context-pad-hover branch April 29, 2024 13:27
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants