Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate types from JavaScript files #1866

Merged
merged 64 commits into from
Apr 19, 2023
Merged

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Mar 9, 2023

A work in progress PR to test automatic type generation.

Tracked via https://github.com/bpmn-io/internal-docs/issues/741.

Notable Changes

  • ReplaceMenuProvider migrated to new PopupMenu API so the deprecated API can be removed (breaking change)

Requires bpmn-io/diagram-js#775.

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Mar 9, 2023
@philippfromme philippfromme changed the title Add Type Declarations for Modeling Add Type Declarations Mar 10, 2023
@nikku nikku marked this pull request as draft March 30, 2023 06:45
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Mar 30, 2023
@philippfromme philippfromme changed the title Add Type Declarations Generate types from JavaScript files Apr 3, 2023
@philippfromme philippfromme force-pushed the type-declarations-2 branch 2 times, most recently from a75502f to 0f0b72f Compare April 4, 2023 07:30
@philippfromme philippfromme force-pushed the type-declarations-2 branch 2 times, most recently from 5a0d9a6 to 95f9d22 Compare April 4, 2023 14:09
@barmac
Copy link
Member

barmac commented Apr 11, 2023

Since the ts tests are colocated with the source code, let's not forget to exclude them from the bundle.

@philippfromme philippfromme force-pushed the type-declarations-2 branch 2 times, most recently from a9a9aea to 6b4378b Compare April 17, 2023 16:30
@philippfromme philippfromme added the needs review Review pending label Apr 18, 2023 — with bpmn-io-tasks
@philippfromme philippfromme removed the in progress Currently worked on label Apr 18, 2023
@philippfromme philippfromme marked this pull request as ready for review April 19, 2023 09:34
@philippfromme philippfromme merged commit 4fa7102 into develop Apr 19, 2023
9 checks passed
@philippfromme philippfromme deleted the type-declarations-2 branch April 19, 2023 10:18
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 19, 2023
@philippfromme philippfromme mentioned this pull request Apr 19, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants