Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct BaseViewer#saveXML definition #1885

Merged
merged 1 commit into from
Apr 4, 2023
Merged

fix: correct BaseViewer#saveXML definition #1885

merged 1 commit into from
Apr 4, 2023

Conversation

nikku
Copy link
Member

@nikku nikku commented Apr 4, 2023

Related to #1881

@nikku nikku requested a review from philippfromme April 4, 2023 12:26
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Apr 4, 2023
philippfromme
philippfromme approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@nikku nikku merged commit f6cd478 into develop Apr 4, 2023
7 of 9 checks passed
@nikku nikku deleted the save-xml-optional branch April 4, 2023 14:04
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme philippfromme approved these changes

Assignees

@nikku nikku

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nikku @philippfromme