Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Checks From diagram-js #1903

Merged
merged 1 commit into from
May 17, 2023
Merged

Use Checks From diagram-js #1903

merged 1 commit into from
May 17, 2023

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented May 4, 2023 •
edited

  • use isConnection, isLabel, isRoot and isShape checks wherever possible

Requires bpmn-io/diagram-js#783
Closes #1901

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label May 4, 2023
@philippfromme philippfromme mentioned this pull request May 4, 2023
Merged
nikku
nikku reviewed May 4, 2023
View reviewed changes
lib/features/copy-paste/BpmnCopyPaste.js Outdated Show resolved Hide resolved
lib/util/LabelUtil.js Outdated
@@ -4,6 +4,10 @@ import {

import { is } from './ModelUtil';

import { isLabel } from 'diagram-js/lib/model';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double import.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to avoid this.

test/spec/features/copy-paste/BpmnCopyPasteSpec.js Show resolved Hide resolved
@philippfromme philippfromme changed the title Use instanceof Checks Use Checks From diagram-js May 4, 2023
@philippfromme philippfromme marked this pull request as ready for review May 15, 2023 16:09
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels May 15, 2023
@philippfromme philippfromme requested a review from nikku May 15, 2023 16:09
@nikku nikku merged commit 37662c9 into develop May 17, 2023
10 checks passed
@nikku nikku deleted the instance-of-checks branch May 17, 2023 06:24
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

Assignees

@philippfromme philippfromme

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deleting Boundary Event Label Deletes Boundary Event
2 participants
@philippfromme @nikku