Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not remove association that was just created #2069

Merged
merged 4 commits into from
Jan 5, 2024

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Jan 5, 2024

Event though we are removing existing associations during preExecute when creating a connection in the case of copy and paste the new connection can already be connected to source and target so we have to make sure we're not trying to remove that connection.

Closes #2068

brave_hr8468rmJD

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jan 5, 2024
@philippfromme philippfromme changed the base branch from develop to main January 5, 2024 09:33
@philippfromme philippfromme force-pushed the fix-compensation-boundary-event-behavior branch from b4d5d32 to fd0e2c0 Compare January 5, 2024 10:55
@philippfromme
Copy link
Contributor Author

Follow-up issue: #2070

@philippfromme philippfromme marked this pull request as ready for review January 5, 2024 11:01
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jan 5, 2024
Copy link
Contributor

@smbea smbea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good

@philippfromme
Copy link
Contributor Author

I think it looks good

That's all that matters. 💅🏻

@philippfromme philippfromme merged commit 3578990 into main Jan 5, 2024
12 checks passed
@philippfromme philippfromme deleted the fix-compensation-boundary-event-behavior branch January 5, 2024 12:37
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Copy and Paste of Comensation Handler Results in an Error
2 participants