Fix outlines #2134
Merged
Fix outlines #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
requested changes
Apr 10, 2024
There was a problem hiding this comment.
Testing this change I can see that the connection outline no longer shows for connections:
This may be a fallout of our "improving selection outline for connections" end of last year, cf. modeler showing only the bendpoints for connections (which does not work in the viewer case):
To be considered:
- Why do we show selection (outline) in the first place? I'd expect the viewer to not ship with visual selection. I'm fine with "hidden selection", i.e. a selectable state that can be reacted to by integrations.
bpmn-io-tasks
bot
added
in progress
|
I tested this change without the diagram styles, the recommended way to embed the viewer. It works with and without the outline module, however I found #2135. Again this sparks the question how much we gain from having selection UI in the viewer. |
bpmn-io-tasks
bot
added
needs review
nikku
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Works fine in recommended viewer distribution => #2134 (comment).
|
Let's target this at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom outlines were only included in modeler.
Closes #2133