Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ESLint 8 #14

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Support ESLint 8 #14

merged 3 commits into from
Jun 23, 2022

Conversation

nikku
Copy link
Member

@nikku nikku commented Jun 21, 2022

This supports the latest eslint version.

The important bit was to update to the latest babel parser (and adjust our JSX parsing accordingly).

We're still testing against both, eslint@7 and eslint@8 on CI.


Closes #11

@nikku nikku requested review from a team, philippfromme and smbea and removed request for a team June 21, 2022 19:25
* test against both eslint@8 and eslint@7 on CI
Not recognized anymore with modern versions of npm.
Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fake-join fake-join bot merged commit 41f38ba into master Jun 23, 2022
@fake-join fake-join bot deleted the eslint-8 branch June 23, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Not compatible with latest eslint version?
2 participants