Removed sorting from ListGroup component

[AlexanderSkrock]

This pull request aims to fix #311 . Currently, it is being developed.

• Remove "shouldSort" property
• Warn if this property is still used
• Adjust testcases
• Write a note in CHANGELOG.md
• Discover dependant components in potentially reliant other projects. This includes to remove the flag and if sorting is necessary to reimplement the sorting on this level.

Closes #311

[nikku]

@AlexanderSkrock Great to see you picking this up. You should be able to link both projects, this core + bpmn-js-properties-panel to test them together:

cd bpmn-js-properties-panel
npm link ../properties-panel

...

[AlexanderSkrock]

This pull request together with changes made in #1047 in bpmn-properties-panel should be good to go now, from my point of view.

One more question, I saw that we released properties-panel version 3.18.2 already, so we would need to increment and also update it for bpmn-js-properties-panel. Is this a step which is done automatically during the release process?

[nikku]

@AlexanderSkrock You'd want to rebase this PR on main before merge.

[nikku]

Once you did it then I can give it my review.

[AlexanderSkrock]

@AlexanderSkrock You'd want to rebase this PR on main before merge.

I checked once again, but it seems my commits were based on main's head already.

[nikku]

Will look into your changes today. Thanks already for your work 👏

[nikku]

After some distractions I hope I find the time to finalize my review + testing tomorrow.

[nikku]

I found the time to review the change, along with bpmn-io/bpmn-js-properties-panel#1047.

A few notes:

• From what it looks to me the change is incomplete. Looking at sorting at the core List#compareFn is used along with sorting to implement sort features; without sorting there is no necessity for compareFn, we want to ditch it which I sketched in bpmn-io/bpmn-js-properties-panel@d883a0f.

• Integration testing Do not sort list items alphabetically bpmn-js-properties-panel#1047 I found a bunch of places where auto focus is now broken; we want to ensure that items are added last to the list (no magic), and focused regardless, sketched for Execution Listeners > Execution Listener > Field injections via bpmn-io/bpmn-js-properties-panel@9953514). Without that change in the relevant places we see the following interaction, shown on the example of User Task (Generated Form): Form Fields > Field > Properties:

  

Other than that the solution feels solid, improves C7, and does not break C8 functionality (where we do not sort already ™️). Good job!

[nikku]

Consider to ditch List#compareFn, cf. #353 (comment).

[nikku]

Waiting for CI to pass before we go ahead and merge this.