fix: Upgrade to raw-loader 2 (like jupyter lab) #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he shaders the same This will allow bqplot to use WebGL within Jupyter lab This replaces bqplot#859
|
Is this ready to be merged? |
|
Doesn't this fix break compatibility with the classic Notebook? Shaders don't seem to compile anymore in the classic Notebook with this fix |
|
did you run npm install again to really install the new webpack? |
|
I guess, because I could get it to work with JupyterLab, but I will check again |
|
Works perfectly for me! I must have had a broken environment back then. @SylvainCorlay would it be ok to merge this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wayt we can load the shaders the same way. This will allow bqplot to use WebGL within Jupyter lab.
raw-loader <2 was using common-js, so you could simply do:
To get the shader string.
Jupyter lab uses raw-loader
~2.0.0, which uses ES module style, requiring you to do:@astrofrog solved this by supporting both cases in #859. However, if we upgrade the devDependencies in bqplot to raw-loader 2, we can use the latter case for bundle building and jupyter lab building.
Replaces #859