Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Install with conan doc pages #1070

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

MikeRavenelle
Copy link

Documentation for conan support.

  • Added conan install documentation and modified section to include it.

Documentation change checklist

  • [ X] My documentation changes follow the docs style guide and any code examples follow the coding style guide.
  • I tested that my change works before raising the PR (via running doxygen, and testing examples).
  • I have not moved any existing pages or changed any existing URLs without strong justification as to why.
  • I have not generated content using AI or a desktop utility such as grammarly.

Copy link
Contributor

Thank you for your contribution, but PRs must be raised against the dev branch. Please log your pull request against the dev branch not master. You can also retarget this pull request, then reopen it.

@github-actions github-actions bot closed this Jan 26, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 26, 2024
@braindigitalis braindigitalis changed the base branch from master to dev January 26, 2024 19:02
@braindigitalis
Copy link
Contributor

reopened and targeted at dev

Copy link
Contributor

@braindigitalis braindigitalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go as soon as Conan is live 👍

@github-actions github-actions bot added the Stale label Mar 27, 2024
@brainboxdotcc brainboxdotcc deleted a comment from github-actions bot Mar 27, 2024
@Jaskowicz1 Jaskowicz1 changed the title Install with conan doc pages docs: Install with conan doc pages Mar 28, 2024
@Jaskowicz1
Copy link
Contributor

Jaskowicz1 commented Mar 28, 2024

Renamed PR to correctly align with our conventions.


```
mkdir build && cd build
conan install .. --build=missing -of=. -s build_type=Release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work on Windows. It seems you can't specify the path if you have -of=..

Doing conan install .. --build=missing -s build_type=Debug seems to fix this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scrap that, I would change this entire thing to be something like the following:

mkdir build
conan install . --output-folder=build --build=missing -s build_type=Release
cd build
cmake .. -DCMAKE_TOOLCHAIN_FILE="conan_toolchain.cmake"
cmake --build build -j8 --config Release

@github-actions github-actions bot added the Stale label May 28, 2024
@brainboxdotcc brainboxdotcc deleted a comment from github-actions bot May 28, 2024
Copy link

netlify bot commented May 28, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit b5a4c9c
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/665571b754f4a10008d4139c
😎 Deploy Preview https://deploy-preview-1070--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants