Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Introduce Tabs component #2678

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

[WIP] Introduce Tabs component #2678

wants to merge 14 commits into from

Conversation

azajac-brl
Copy link
Contributor

@azajac-brl azajac-brl commented Feb 21, 2023

Missing:

  • Chromatic tests
  • A11y tests
  • Interfaces for CSS variables
  • kebab-case for CSS variables
  • Extended documenation (showing different subcomponents and their props)
  • Handling reduce-motion for ActiveIndicator
  • Working solution for a11y ids (current implementation might not work if rendered server-side)
  • Instead of animating width we should animate scaleX
  • keyboard support
  • a11y compliance
  • Handle in Tab text children and component children

@azajac-brl azajac-brl requested a review from a team as a code owner February 21, 2023 16:07
This commit changes styling of active indicator as well.
That's because of Transition component overwriting style attribute.
@coderitual
Copy link
Contributor

coderitual commented Feb 21, 2023

thx @azajac-brl , could you please add to the list:

  • "keyboard support"
  • "a11y compliance"

as for

Working solution for a11y ids

please take a look here:
https://brainly.atlassian.net/wiki/spaces/DesignSystem/pages/1274871849/Isomorphic+IDs+in+the+style+guide+for+accessibility+attributes

and example:

suppressHydrationWarning

@coderitual
Copy link
Contributor

coderitual commented Feb 22, 2023

hey @azajac-brl, when it comes to accessibility and keyboard support. I know that @katarzynatobis and @bartoszlorek were working on similar support for some segmented-like/tab component in the app. Maybe that PR would be a good reference for applying same support here?

@azajac-brl
Copy link
Contributor Author

azajac-brl commented Feb 22, 2023

hey @azajac-brl, when it comes to accessibility and keyboard support. I know that @katarzynatobis and @bartoszlorek > were working on similar support for some segmented-like/tab component in the app. Maybe that PR would be a good > reference for applying same support here?

Thanks for letting me know! I'll reach out to them about that! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants