fix: fix issue #24, #22, #17 #26
Open
+213
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deskid thanks! |
|
Hi @deskid with this PR, when the views are recycled inside RecyclerView has a strange behavior. Can you review it? |
|
yes, I have noticed that strange behavior. Thank you. I think it is due to the recycled view's inner expanded-state re-used, so offer a method to reset the state when view is rebinded will fix that. I will find time to fix it and update this PR |
|
Yes, I think the problem is that. Thank you so much! |
|
@bravoborja updated |
|
@deskid your changes will disable native text selection in the textview. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry, I should have made 3 PR for 3 issues
and I add a RecyclerView in demo app