Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jet-brains-integration] feature request, option to set the default-icon for web-types.json #99

Closed
veith opened this issue Mar 8, 2024 · 4 comments · Fixed by #100
Closed

Comments

@veith
Copy link
Contributor

veith commented Mar 8, 2024

Displaying your icon on the code completion list in intellij is a nice feature.

@veith veith changed the title [jet-brains-integration] feature request option to set the default-icon for web-types.json [jet-brains-integration] feature request, option to set the default-icon for web-types.json Mar 8, 2024
@break-stuff
Copy link
Owner

break-stuff commented Mar 8, 2024

I didn't know this was a feature. Can you provide an example of what it does exactly (like a screenshot or something)?

@veith
Copy link
Contributor Author

veith commented Mar 8, 2024

Sure

Example without the option default-icon set:
Screenshot 2024-03-08 at 13 43 34

Example with default-icon option set:
Screenshot 2024-03-08 at 13 43 05

@veith
Copy link
Contributor Author

veith commented Mar 8, 2024

And if you just type something like "card" they are mixed together.

Screenshot 2024-03-08 at 13 49 07

I have created a pull request #100 with tests, if you want to check it.

@break-stuff
Copy link
Owner

Oh, that's really nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants