Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/webtypes default icon #100

Merged
merged 4 commits into from Mar 14, 2024

Conversation

veith
Copy link
Contributor

@veith veith commented Mar 8, 2024

option for adding a default-icon added.

closes #99

@break-stuff
Copy link
Owner

Does the icon need to be included in the project or can it reference a URL?

@break-stuff
Copy link
Owner

Would you be willing to update the README.md with information about this?

@veith
Copy link
Contributor Author

veith commented Mar 10, 2024

During adding the documentation i spotted that referencesTemplate is wrong documented. The Options type wants a referenceTemplate. And after playing with this option, i realised that the code is never called.

I will file another issue on this.

@veith
Copy link
Contributor Author

veith commented Mar 11, 2024

Would you be willing to update the README.md with information about this?

done

@veith
Copy link
Contributor Author

veith commented Mar 14, 2024

@break-stuff Is there any other actions from my side expected before merge?

@break-stuff
Copy link
Owner

I think we're good! Thank you!

@break-stuff break-stuff merged commit e0aa044 into break-stuff:main Mar 14, 2024
1 check passed
@veith veith deleted the feat/webtypes-default-icon branch March 14, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[jet-brains-integration] feature request, option to set the default-icon for web-types.json
2 participants