fix: dialyzer errors on Elixir 1.16 #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type check fails when using Elixir 1.16.
|
This is the same as #18 but keeps support for older Elixir versions. |
|
Do you know why does dialyzer fail on this ? The read ahead option seems to be declared in the |
|
Ah ok it's about the order of arguments.
Edit: well that's what the other PR does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the code still works, dialyzer fails when using Elixir 1.16.
The fix is the same as described in this comment: elixir-lang/elixir#13212 (comment). I’ve removed the
:read_aheadoption as I understand Elixir will add it with a reasonable value by default. Let me know your thoughts about this.