Fixes for hanging issue

[pawelglosz]

Hello @brendanmorrell ,
I've fixed 2 bugs with my current changes:

• removed cloneDeep(), it looks like that at the end it wasn't needed at all
• fixed support for ChainExpressions as a jsx attributes (there was an error The prop value with an expression type of ChainExpression could not be resolved for such cases)

[pawelglosz]

Also, I've checked the functionality and performance on my few projects, everywhere it seems to work fine.

[brendanmorrell]

Awesome. Thanks, Pawel, and my apologies for not getting back to you about the issues. I read the email while I was busy, and I forgot about it until now. I'll try and take a look asap and then we can cut a release. Thanks again!

…

On Tue, Jul 12, 2022 at 6:50 AM pawelglosz ***@***.***> wrote: Also, I've checked the functionality and performance on my few projects, everywhere it seems to work fine. — Reply to this email directly, view it on GitHub <#41 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADRNADLZNHMPPXEKOYOWBQLVTVZ2HANCNFSM53LDMGDA> . You are receiving this because you were mentioned.Message ID: <brendanmorrell/eslint-plugin-styled-components-a11y/pull/41/c1181785926@ github.com>

[pawelglosz]

Please be aware, that there might be some breaking changes for some environments because of a major version update of jsx-ast-utils - it was needed for the ChainingExpression issue, please see the thread here: facebook/react#19940 (comment)

[brendanmorrell]

Noted. Thanks, Pawel

…

On Wed, Jul 13, 2022 at 1:31 AM pawelglosz ***@***.***> wrote: Please be aware, that there might be some breaking changes for some environments because of a major version update of jsx-ast-utils - it was needed for the ChainingExpression issue, please see the thread here: facebook/react#19940 (comment) <facebook/react#19940 (comment)> — Reply to this email directly, view it on GitHub <#41 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADRNADO5SJUU5QLEOEAC6QTVTZ5F5ANCNFSM53LDMGDA> . You are receiving this because you were mentioned.Message ID: <brendanmorrell/eslint-plugin-styled-components-a11y/pull/41/c1182929205@ github.com>

[pawelglosz]

Hello @brendanmorrell , any updates around this? :)

[brendanmorrell]

hey, pawel. very sorry. have been super busy. thank you for fixing the issue. i will do my best to test and get a new version out tonight

…

On Mon, Jul 25, 2022 at 3:46 AM pawelglosz ***@***.***> wrote: Hello @brendanmorrell <https://github.com/brendanmorrell> , any updates around this? :) — Reply to this email directly, view it on GitHub <#41 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADRNADIIRFVUMXHFLOT55WDVVZV7HANCNFSM53LDMGDA> . You are receiving this because you were mentioned.Message ID: <brendanmorrell/eslint-plugin-styled-components-a11y/pull/41/c1193884659@ github.com>

[brendanmorrell]

So, everything looking good when i run the project locally. Only thing I notice is that the code you added only fires an error if the styled component is defined inside of the object where you are placing it. if it is defined outside of the object, the rule no longer fires. I don't use this pattern personally, so not sure how much of an issue that is. If it isn't an accepted version of this pattern and you don't think an update is necessary, I'm good merging this and releasing a new version.

[pawelglosz]

It won't be an issue, I think we can release it as it is. I'll look at the case with a styled component defined outside of the object and try to add support for it as well. But this can be done in another release.

[brendanmorrell]

merged. new version with this change is 1.0.0. Thanks again, Pawel!

[pawelglosz]

Thank you! I'll try to look into the case with a styled component defined outside of the object as soon as possible :)