examples: replace structopt with clap #357
Conversation
|
@Johann150 perhaps? Unclear if this repository is maintained. |
|
Please check your code formatting (or run There also seems to be an issue with the minimum supported Rust version so CI will probably not completely pass still, but I don't feel qualified to change that. I'm just a collaborator, not a maintainer of this package. |
tamird
force-pushed
the
clap
branch
2 times, most recently
from
609b5aa
to
9b36246
Compare
|
Both issues should be fixed now. Could you trigger another run? |
tamird
force-pushed
the
clap
branch
2 times, most recently
from
45d9ad7
to
8cbad6c
Compare
|
One more attempt please! Should be fixed now. Implementing "possible values" on foreign types is a bit clumsier now. |
|
Looks like we'd need to bump MSRV to 1.56 fro 1.46 to allow this to land. See description in d-e-s-o/test-log@9619698. |
|
Would you mind allowing CI to run again? |
|
Sadly have to bump further to 1.60. Could you run CI again? |
|
Needed to update the arguments to |
|
Once more please! Need 1.61. |
|
@Johann150 this is finally green. If you are not able to approve this MSRV bump, can you ping someone who is? |
|
I don't think it makes sense to raise the MSRV for the entire library just because one of the examples requires it. It would probably be a better idea to use another parsing framework, e.g. |
See TeXitoi/structopt#525. Currently codespan-reporting is the second most downloaded dependent of structopt: https://crates.io/crates/structopt/reverse_dependencies.
This type doesn't provide any value over ColorChoice, which is already FromStr.
|
Done. I added another commit to remove ColorArg, but I can withdraw it if you prefer. |
|
@Johann150 can you please run CI? |
|
@Johann150 ping. |
|
@Johann150 could you have a look please? |
See TeXitoi/structopt#525.
Currently codespan-reporting is the most downloaded dependent of
structopt: https://crates.io/crates/structopt/reverse_dependencies.